Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx: add entry for /api, use client_max_body_size #1924

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Oct 9, 2023

When running oci-env, I can not upload some collections, because the upload size limit is too small.

On actual galaxy.ansible.com, this is 20M, but the oci-env config uses a 10M default, only overriding it for /pulp/api/v3/ (in https://github.com/pulp/pulp-oci-images/blob/latest/images/s6_assets/nginx.conf#L62).

Our api calls go to /api/automation-hub/, /api/galaxy/ or /api/ so that client_max_body_size 0; doesn't apply.


I'm assuming this is something to fix in galaxy_ng, as those URLs are galaxy-specific, is that right?

(=> added an /api/ entry in the galaxy_ng nginx snippet, copied from /pulp/api/v3 in pulp-oci-images)


Testing: try uploading arista.avd 4.2.0 from the UI.

@github-actions github-actions bot added backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Oct 9, 2023
@himdel himdel removed backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Oct 9, 2023
Copy link
Contributor

@jerabekjiri jerabekjiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and LGTM 👍

@himdel himdel merged commit 9f1cb9d into ansible:master Oct 12, 2023
19 of 20 checks passed
@himdel himdel deleted the dev-upload branch October 12, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants